feat(metricsai): default week-ending day to Friday - #42
Merged
Conversation
Change the default reporting-week close from Thursday to Friday. The window is always the 7 days ending on the week-ending day, so the default window shifts to Sat 00:00:00Z-Fri 23:59:59Z. The day remains overridable via week_ending_day / METRICSAI_WEEK_ENDING_DAY / --week-ending-day. Updates the two source defaults plus docstrings, CLI help, the two default-specific model tests, and all docs (README, QUICKSTART, docs/usage, CLAUDE.md). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes the metricsai default week-ending day from Thursday to Friday.
week_ending_datedefaults to the most recent occurrence of the configuredweek-ending weekday. Flipping the default flips the implied reporting window —
since the window is always "the 7 days ending on that day," the default window
moves from Fri 00:00:00Z-Thu 23:59:59Z to Sat 00:00:00Z-Fri 23:59:59Z.
The day is still overridable via
week_ending_day/METRICSAI_WEEK_ENDING_DAY/
--week-ending-day; only the default changed.Changes
DEFAULT_WEEK_ENDING_WEEKDAYin
models.pyandweek_ending_dayinconfig.py.models.py,context.py,config.py, and the--week-ending-dayhelp text incli.py.tests/test_models.pyto Friday dates (2026-06-05).
README.md,QUICKSTART.md,docs/usage.md,CLAUDE.md.Verification
uv run pytest— 57 passed.metricsai --module build_pr --dry-run→week_ending_date: 2026-06-12(Friday).metricsai --week-ending-day thursday --module build_pr --dry-run→2026-06-11(override still works).🤖 Generated with Claude Code